[RHCLOUD-19829] Fixed logging type #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psav
force-pushed
the
psav/fix_logging_type
branch
from
c5612c4 to
833ced7
Compare
psav
added
bug
|
We are hitting this issue that the logging type isn't set. This could be fixed since 2022. |
avisiedo
added a commit
to avisiedo/idmsvc-backend
that referenced
this pull request
Mar 20, 2024
Temporary workaround that fill type with "cloudwatch" string when we fill the cloudwatch configuration. Once the referenced PR is merged, we can remove See: RedHatInsights/clowder#627 Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
added a commit
to avisiedo/idmsvc-backend
that referenced
this pull request
Mar 20, 2024
Temporary workaround that fill type with "cloudwatch" string when we fill the cloudwatch configuration. Once the referenced PR is merged, we can remove See: RedHatInsights/clowder#627 Signed-off-by: Alejandro Visiedo <[email protected]>
|
/retest |
bsquizz
approved these changes
Mar 21, 2024
| - script: kubectl get secret --namespace=test-log-none puptoo -o json > /tmp/test-log-none | ||
| - script: jq -r '.data["cdappconfig.json"]' < /tmp/test-log-none | base64 -d > /tmp/test-log-none-json | ||
|
|
||
| - script: jq -r '.logging.type == "null"' -e < /tmp/test-log-none-json |
There was a problem hiding this comment.
I thought we left null keys absent these days, but I can see this has been in place in the code for awhile so probably not worth changing just for this simple fix.
avisiedo
added a commit
to podengo-project/idmsvc-backend
that referenced
this pull request
Apr 2, 2024
Temporary workaround that fill type with "cloudwatch" string when we fill the cloudwatch configuration. Once the referenced PR is merged, we can remove See: RedHatInsights/clowder#627 Signed-off-by: Alejandro Visiedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.