Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APIv2): RHINENG-2875 implement tailorings endpoint #1885

Closed
wants to merge 4 commits into from
Closed

feat(APIv2): RHINENG-2875 implement tailorings endpoint #1885

wants to merge 4 commits into from

Conversation

romanblanco
Copy link
Member

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch 8 times, most recently from ece1961 to 2b8cb23 Compare December 7, 2023 11:56
skateman
skateman requested changes Dec 7, 2023
View reviewed changes
config/routes.rb Outdated Show resolved Hide resolved
spec/controllers/v2/tailorings_controller_spec.rb Outdated Show resolved Hide resolved
spec/factories/tailoring.rb Outdated Show resolved Hide resolved
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch 8 times, most recently from cc6727e to 753d2ce Compare December 12, 2023 13:34
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch 2 times, most recently from ff55c85 to 0ab02ac Compare December 14, 2023 14:14
@romanblanco romanblanco added the APIv2 REST API v2 label Dec 14, 2023
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch 8 times, most recently from 9916cb2 to 33f45af Compare December 21, 2023 20:11
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch 2 times, most recently from aac28b6 to 10097b0 Compare January 3, 2024 19:30
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch 2 times, most recently from ea8518c to 42bda41 Compare January 11, 2024 15:22
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch 5 times, most recently from 1164033 to b3d4015 Compare January 18, 2024 14:21
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch 2 times, most recently from 5c444a5 to c66e3b9 Compare January 26, 2024 12:12
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch from c66e3b9 to 4d05d01 Compare January 29, 2024 11:58
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch from 4d05d01 to 8276c44 Compare January 30, 2024 08:51
@romanblanco romanblanco force-pushed the RHINENG-2875-apiv2-tailorings branch from 8276c44 to 2815784 Compare January 30, 2024 15:08
skateman
skateman requested changes Jan 31, 2024
View reviewed changes
app/controllers/v2/tailorings_controller.rb Show resolved Hide resolved
app/controllers/v2/tailorings_controller.rb Show resolved Hide resolved
app/models/v2/rule_group.rb Show resolved Hide resolved
app/models/v2/tailoring.rb Show resolved Hide resolved
app/models/v2/tailoring.rb Show resolved Hide resolved
spec/factories/tailoring.rb
tailoring: tailoring
)
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need a trait about randomly shuffled rules where not only the rules of the parent profile are mixed in, but other ones from the security guide as well.

spec/factories/tailoring_rule.rb Show resolved Hide resolved
spec/fixtures/files/searchable/tailorings_controller.yaml Show resolved Hide resolved
spec/fixtures/files/sortable/tailorings_controller.yaml Show resolved Hide resolved
spec/fixtures/files/sortable/tailorings_controller.yaml Show resolved Hide resolved
@romanblanco romanblanco closed this Feb 1, 2024
romanblanco
romanblanco commented Feb 9, 2024
View reviewed changes
spec/controllers/v2/tailorings_controller_spec.rb
:with_rules,
os_major_version: 8,
ref_id_suffix: 'foo',
supports_minors: [version]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: We can support multiple minor RHEL versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman requested changes

@RoamingNoMaD RoamingNoMaD RoamingNoMaD left review comments

Assignees
No one assigned
Labels
APIv2 REST API v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanblanco @skateman @RoamingNoMaD