Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCXDEV-12127] Fix payload-tracker support #29

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

matysek
Copy link
Member

@matysek matysek commented Jan 26, 2024

Description

Add proper service_name for the payload tracker. Payload tracker is supported out-of-the-box by the insights-ccx-messaging library. This fixes the service name used for payload-tracker kafka messages.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@juandspy
Copy link
Collaborator

why do we need to set it explicitly if that's not needed in ccx-data-pipeline? I've seen in sha-extractor we also set it 🤔

@matysek
Copy link
Member Author

matysek commented Jan 26, 2024

Because of this line in ccx-messaging - 'ccx-data-pipeline' is set as default name:
https://github.com/RedHatInsights/insights-ccx-messaging/blob/main/ccx_messaging/watchers/payload_tracker_watcher.py#L34

@juandspy
Copy link
Collaborator

Because of this line in ccx-messaging - 'ccx-data-pipeline' is set as default name: https://github.com/RedHatInsights/insights-ccx-messaging/blob/main/ccx_messaging/watchers/payload_tracker_watcher.py#L34

TY! I think it's not a good practice to have a default value there. In any case, LGTM!

@matysek
Copy link
Member Author

matysek commented Jan 26, 2024

in dvo-extractor we have this line:

{"filename": "payload_tracker_watcher.py", "lineno": 58, "process": 1, "levelname": "INFO", "asctime": "2024-01-26 12:18:39,942", "name": "ccx_messaging.watchers.payload_tracker_watcher", "message": "Sending status reports to Payload Tracker on topic platform.payload-status as service ccx-data-pipeline"}

@juandspy
Copy link
Collaborator

in dvo-extractor we have this line:

{"filename": "payload_tracker_watcher.py", "lineno": 58, "process": 1, "levelname": "INFO", "asctime": "2024-01-26 12:18:39,942", "name": "ccx_messaging.watchers.payload_tracker_watcher", "message": "Sending status reports to Payload Tracker on topic platform.payload-status as service ccx-data-pipeline"}

Ye... That's a problem IMO. We shouldn't use payload tracker if we don't have enough arguments f.e. missing service name. Let's discuss it some day.

@matysek matysek merged commit 8d553da into RedHatInsights:master Jan 26, 2024
8 checks passed
@matysek matysek deleted the mzibrick-ccxdev12127 branch January 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants