Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove system flag to use public_tenant for access consistency #1451

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EvanCasey13
Copy link
Contributor

@EvanCasey13 EvanCasey13 commented Jan 21, 2025

Link(s) to Jira

https://issues.redhat.com/browse/RHCLOUD-30435

Description of Intent of Change(s)

Use public_tenant to access instead of system flag for consistency, replaced all filtering by public_tenant to use public_tenant_only() for consistency in public tenant filtering.

Local Testing

How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?

Checklist

  • if API spec changes are required, is the spec updated?
  • are there any pre/post merge actions required? if so, document here.
  • are theses changes covered by unit tests?
  • if warranted, are documentation changes accounted for?
  • does this require migration changes?
    • if yes, are they backwards compatible?
  • is there known, direct impact to dependent teams/components?
    • if yes, how will this be handled?

Secure Coding Practices Checklist Link

Secure Coding Practices Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@@ -105,7 +105,7 @@ def clone_default_group_in_public_schema(group, tenant) -> Optional[Group]:
group_uuid = uuid4()

public_tenant = Tenant.objects.get(tenant_name="public")
tenant_default_policy = group.policies.get(system=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the policies, the situation is different, we used system True to indicate the policies can not be updated, but the tenant is in each tenant. Maybe we can just ignore the system=True for policies. You might need to do some research if we have any system not true policies

@EvanCasey13 EvanCasey13 reopened this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants