-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new redhat-cloud-client-configuration-cdn binary package #15
base: main
Are you sure you want to change the base?
Conversation
a1c4c63
to
c37b149
Compare
/packit build |
c37b149
to
66a9430
Compare
/packit build |
66a9430
to
da9dfd9
Compare
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the patch looks good. I'd like a clarification on rhcd/yggdrasil handling.
Explicitly lists all the files that are installed as part of the redhat-cloud-client-configuration binary package: this way, when new files will be added for other binary packages, they will not be implicitly installed in redhat-cloud-client-configuration. There is no behaviour change. Signed-off-by: Pino Toscano <[email protected]>
Create a new redhat-cloud-client-configuration-cdn binary package as exact copy of the redhat-cloud-client-configuration binary package. Since they are supposed to cover different use cases, and thus never installed together, ensure that each conflicts against the other one. Signed-off-by: Pino Toscano <[email protected]>
The redhat-cloud-client-configuration-cdn binary package will ensure that the registered system will fetch the content from the default CDN configured in subscription-manager. Hence, drop the bits from the %post and %postun scriptlets of the package that tweak the "manage_repos" configuration option of subscription-manager. Signed-off-by: Pino Toscano <[email protected]>
The redhat-cloud-client-configuration-cdn binary package will ensure that the system does not get content via RHUI by default, in case it is installed, as that is what the automatic registration of subscription-manager will provide. Because of that: - create /var/lib/rhui/disable-rhui on installation (removing it on removal) to tell RHUI to not enable any repository; this happens during the upgrade of the RHUI packages - create a boot systemd service that runs a script which tries to disable all the non-public RHUI repositories available (typically the RHEL repositories) - both the systemd service and the script should work also when RHUI is not installed - the service will run only once when /etc/rhccc-firstboot-run is available Signed-off-by: Pino Toscano <[email protected]>
da9dfd9
to
67b5a6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's wait for QE ack before merging.
The existing
redhat-cloud-client-configuration
binary package has a well-defined behaviour when used in cloud images:Since soon a different behaviour will be needed, then create a new
redhat-cloud-client-configuration-cdn
binary package to represent that behaviour separately:/etc/rhccc-firstboot-run
is there, which will be touch'ed when creating the cloud images withredhat-cloud-client-configuration-cdn
See the messages of the individual commits for more details.
Card ID: CCT-701