Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.22 #288

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Upgrade to Go 1.22 #288

merged 1 commit into from
Jan 31, 2025

Conversation

upadhyeammit
Copy link
Contributor

PR Title 💥

Please title this PR with a summary of the change, along with the JIRA card number.

Suggested formats:

  1. Fixes/Refs #RHIROS-XXX - Title
  2. RHIROS-XXX Title
  3. RHINENG-XXX Title

Feel free to remove this section from PR description once done.

Why do we need this change? 💭

Please include the context of this change here. If the change depends on Kruize add details about that as well!

Documentation update? 📝

  • Yes
  • No

Security Checklist 🔒

Upon raising this PR please go through RedHatInsights/secure-coding-checklist

💂‍♂️ Checklist 🎯

  • Does this change depend on specific version of Kruize
    • If yes what is the version no:
    • Is that image available in production or needs deployment?
  • Bugfix
  • New Feature
  • Refactor
  • Unittests Added
  • DRY code
  • Dependency Added
  • DB Migration Added

Additional 📣

Feel free to add any other relevant details such as links, notes, screenshots, here.

@upadhyeammit upadhyeammit force-pushed the go-1.22 branch 2 times, most recently from d275846 to 9d3aaf9 Compare December 19, 2024 16:15
@upadhyeammit
Copy link
Contributor Author

/retest

3 similar comments
@upadhyeammit
Copy link
Contributor Author

/retest

@upadhyeammit
Copy link
Contributor Author

/retest

@upadhyeammit
Copy link
Contributor Author

/retest

@kgaikwad
Copy link
Collaborator

As per today's updates meeting, it seems this PR is waiting for PR #282 to go first into main.
Note that final review is also pending.

@upadhyeammit
Copy link
Contributor Author

/retest

1 similar comment
@upadhyeammit
Copy link
Contributor Author

/retest

Copy link
Contributor

@saltgen saltgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upadhyeammit As discussed, request you to share context for this change, rest lgtm, changes tested locally.

@saltgen
Copy link
Contributor

saltgen commented Jan 30, 2025

@upadhyeammit As discussed, request you to share context for this change, rest lgtm, changes tested locally.

https://github.com/RedHatInsights/ros-ocp-backend/pull/288/files#diff-7e4ba9264afd9eae1dce0c185a9141edf9c02bb44b0b76d19877389b71624006R28-R36

@upadhyeammit
Copy link
Contributor Author

@upadhyeammit As discussed, request you to share context for this change, rest lgtm, changes tested locally.

https://github.com/RedHatInsights/ros-ocp-backend/pull/288/files#diff-7e4ba9264afd9eae1dce0c185a9141edf9c02bb44b0b76d19877389b71624006R28-R36

Without my change the report processor fails as,

FATA[0079]/home/amit/work/insights/ros/ros-ocp-backend/internal/db/db.go:35 github.com/redhatinsights/ros-ocp-backend/internal/db.initDB() cannot parse `user=postgres password=xxxxx dbname=postgres host=localhost port=15432 sslmode=disable sslrootcert=/tmp/RdsCa.pem409147796`: failed to configure TLS (unable to add CA to cert pool)  account= cluster_alias=name222 cluster_uuid=222 org_id=3340851 request_id=uuid1234 service=rosocp source_id=111
exit status 1
make: *** [Makefile:63: run-processor] Error 1

Copy link
Contributor

@saltgen saltgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @upadhyeammit for the changes!

@saltgen saltgen merged commit 017c94c into RedHatInsights:main Jan 31, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants