Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evaluator): inherit cve statuses for new system evaluated vulner… #1541

Closed

Conversation

yungbender
Copy link

…abilities

RHINENG-2381

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Oct 26, 2023

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-2381

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9b5dd4e) 68.32% compared to head (8360cdd) 68.27%.

Files Patch % Lines
evaluator/logic.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1541      +/-   ##
==========================================
- Coverage   68.32%   68.27%   -0.05%     
==========================================
  Files          53       53              
  Lines        5957     5961       +4     
==========================================
  Hits         4070     4070              
- Misses       1887     1891       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdobes
Copy link
Member

jdobes commented Oct 30, 2023

I'm not going to merge this because status_id column in system_vulnerabilities is going to be deprecated in favor of #1487

@jdobes
Copy link
Member

jdobes commented Oct 31, 2023

Let's wait until #1487 is done.

@jdobes jdobes added the onhold label Oct 31, 2023
@yungbender yungbender force-pushed the inherit_cve_Status branch 2 times, most recently from ddb00b5 to 9473b41 Compare November 16, 2023 14:57
@yungbender yungbender removed the onhold label Nov 16, 2023
@yungbender yungbender requested a review from jdobes November 16, 2023 14:57
@mtclinton
Copy link
Contributor

/retest

@yungbender yungbender force-pushed the inherit_cve_Status branch 2 times, most recently from d2c7243 to 744030a Compare November 29, 2023 15:41
@jdobes jdobes force-pushed the inherit_cve_Status branch from 558d314 to 135cf1d Compare December 12, 2023 13:54
@jdobes jdobes force-pushed the inherit_cve_Status branch from 135cf1d to 8360cdd Compare December 18, 2023 13:23
@jdobes
Copy link
Member

jdobes commented Dec 19, 2023

Closing in favor of different approach.

@jdobes jdobes closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants