Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager): add API throttling per account #1558

Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat(manager): add API throttling per account #1558

merged 1 commit into from
Nov 29, 2023

Conversation

michalslomczynski
Copy link
Contributor

@michalslomczynski michalslomczynski commented Nov 24, 2023 •
edited
Loading

RHINENG-2585

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking Jira Linking
Copy link

jira-linking bot commented Nov 24, 2023 •
edited
Loading

Commits missing Jira IDs:
f740e12

@michalslomczynski michalslomczynski force-pushed the api-throttling branch 5 times, most recently from 08ba087 to fa620bf Compare November 25, 2023 11:03
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e25166) 68.47% compared to head (f740e12) 68.51%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
+ Coverage   68.47%   68.51%   +0.03%     
==========================================
  Files          53       53              
  Lines        5926     5933       +7     
==========================================
+ Hits         4058     4065       +7     
  Misses       1868     1868

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yungbender
yungbender suggested changes Nov 27, 2023
View reviewed changes
Copy link

@yungbender yungbender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looking good!

run_tests.sh Outdated Show resolved Hide resolved
manager/main.py Outdated Show resolved Hide resolved
yungbender
yungbender reviewed Nov 27, 2023
View reviewed changes
manager/main.py Outdated Show resolved Hide resolved
@michalslomczynski michalslomczynski force-pushed the api-throttling branch 4 times, most recently from 283b143 to c611af9 Compare November 28, 2023 10:47
@jdobes
Copy link
Member

jdobes commented Nov 29, 2023

/retest

@yungbender yungbender merged commit ae2d84d into RedHatInsights:master Nov 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungbender yungbender yungbender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalslomczynski @codecov-commenter @jdobes @yungbender