Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Status modal): Update info text about future CVEs #2188

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Jan 3, 2025

https://issues.redhat.com/browse/RHINENG-15021

  • Change the wording
  • Remove tooltip, as it's redunant
  • Use the PF5 Alert component for visual consistency

Before:

Screenshot from 2025-01-03 14-28-35

After:

Screenshot from 2025-01-03 14-36-46

@leSamo leSamo requested a review from a team as a code owner January 3, 2025 13:26
Copy link

jira-linking bot commented Jan 3, 2025

Commits missing Jira IDs:
e64bb19
b3cebde
2a06b55

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.11%. Comparing base (783dc52) to head (2a06b55).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2188   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files         129      129           
  Lines        3473     3473           
  Branches     1104     1104           
=======================================
  Hits         2331     2331           
  Misses       1142     1142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LightOfHeaven1994 LightOfHeaven1994 merged commit ea0ee8f into master Jan 7, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants