Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVSSv4, fixes to unexpected severity results #49

Closed
wants to merge 0 commits into from
Closed

CVSSv4, fixes to unexpected severity results #49

wants to merge 0 commits into from

Conversation

jobiewinserapck
Copy link
Contributor

@jobiewinserapck jobiewinserapck commented Dec 19, 2023 •
edited
Loading

  • falcochu noticed that the json 'baseSeverity' was not returning a result and the severity for a score of 6.9 was incorrect
  • The severity calculation was evaluating float(6.9) > D("6.9"), it now evaluates float(6.9) <= float(6.9) correctly
  • json 'baseSeverity' now correctly returns the object's severity
  • Added a severity test for CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:L/VI:L/VA:L/SC:L/SI:L/SA:L
  • Added as_json test evaluation to run_tests_from_file
  • Added as_json tests to test_severity

@jobiewinserapck jobiewinserapck mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jobiewinserapck