Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CVSS2, CVSS3): add methods to fetch isolated temporal and environmental vectors #64

Conversation

fqlenos
Copy link
Contributor

@fqlenos fqlenos commented Sep 28, 2024

This Pull Request introduces an enhanced feature that allows users to fetch isolated Temporal and Environmental CVSS vectors specifically for both CVSS version 2.0 and the 3.X series.

The isolated vectors provide a more granular view of vulnerabilities by separating the base metrics from the Temporal and Environmental metrics.

Additionally, the unit tests have been modified to ensure that these changes are properly implemented and validated.

@fqlenos
Copy link
Contributor Author

fqlenos commented Sep 28, 2024

In the case of accepting this feature, would it be possible to generate a new release of the library with the latest changes applied so far?

Thanks in advance :)

@skontar skontar requested review from jsvob and jobselko September 30, 2024 10:22
Copy link
Collaborator

@jsvob jsvob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution! I'll let @jobselko review too since I'm not familiar with the project as much as I'd like.

@jobselko
Copy link
Collaborator

Hi, I am sorry for the delay. I will look into it next week.

Copy link
Collaborator

@jobselko jobselko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to separate commits by version so that each commit contains code and tests for the given version, but otherwise, LGTM!

@fqlenos
Copy link
Contributor Author

fqlenos commented Oct 30, 2024

@jobselko sure! I have no problem with doing it in two parts :)
Thank you all!

@skontar skontar merged commit 42a77b6 into RedHatProductSecurity:master Oct 30, 2024
10 checks passed
@skontar
Copy link
Collaborator

skontar commented Oct 30, 2024

@fqlenos we have another update to CVSS v4.0 rounding worked on, so expect release afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants