-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSIDB-2818: Affect section redesign #371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f05d10
to
c0aec18
Compare
97c8d0c
to
402fce2
Compare
127a240
to
7cfb8ad
Compare
MrMarble
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that important, but normally __fixtures__
is the word used instead of __sampledata__
I'll continue the review later, I'm still missing some files
b9d73a4
to
5eda9e9
Compare
c43a529
to
7b071f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSIDB-2818 Affect section redesign
Checklist:
Summary:
Performs the re-design of the full
Affected Offerings
section, providing new components for Affects, Trackers and Tracker Manager views. It also covers some fixes, provides new functionalities, removes deprecated/old code and aims to improve components naming and hierarchy.Almost all changes are UI related, but there are specific minimal changes on
FlawAffectsModel
(for having added affects as a parameter) anduseTrackers
(forloading
functionality and improve selection toggling)Note!: The PR shouldn't be merged until approval from VM team on last changes (meeting on Thursday 08/08),
but as most of the changes have been already approved/requested by them, not many things are likely to change, so it can start being reviewed.
Changes:
General
FlawAffects
,FlawTrackers
andTrackersManager
Affected Modules
filter list on the start of the sectionapiKeys
toosimSettings
and storage fromOSIM::API-KEYS
toOSIM::USER-SETTINGS
as they are now not limited to the api keysmodal-dialog
onModal
widget to be able to apply parent classes and stylesusePagination
composableAffects View
Affectedness
,Resolution
andImpact
fieldsFlawAffects
componentTrackers View
affected module
information, now getting it from affects mappingBug ID
informationType
informationStatus
fieldResolution
columnTrackers Manager View
TrackersManager
within the trackers viewTrackersManager
for individual/selected affectsTrackersManayer
for a more compact viewTrackersManager
style for a more homogeneous viewTests
SampleData
for more flexible and wide dummy dataFlawAffects
componentFlawTrackers
componentTrackersManager
componentConsiderations:
All existing test suites for old affect section and trackers have been removed as they were covering correct UI placement, I didn't add such tests for new views considering to rely on the recently implemented snapshots tests.
I considered the rename of the 'Trackers Manager' individual section parts (Available Trackers | Selected to file | Already Filed | Untrackable Affects)
Also considered a sightly adjustment on the
Trackers Manager
layout/UI aiming for a bit more homogeneous style in the individual parts. For this purpose the untrackable affects style have been modified and the information text have been moved into a icon tooltip to optimize the space.Keeping full flaw trackers manager can seem redundant as it is possible open the manager form the selection of all affects, but it was decided to keep it as it provides a different view that doesn't cover the trackers table (as the modal does) for the cases that is needed to manage trackers looking at the table at the same time
I finally considered not adding affects/trackers per page on user settings view to wait to have more OSIM custom UI settings to add so when provided to the users it offers a more extensive settings.
I consider it would be nice to update the scss color palettes to have a consistent set of reusable variable colors
As a side note I noticed widget page (only visible in dev) is kind f broken, I suggest removing it unless someone is/will use it.
Screenshots
Affected Modules Filters
Affects Table Toolbar
Affects Table
Modal Tracker Manager (loading)
Modal Tracker Manager (loaded)
Trackers Table
Embedded Trackers Manager
No Affects View
Demos
Changes after the demo recordings:
OSIM-AffectsSectionRedesign-1.mp4
OSIM-AffectsSectionRedesign-2.mp4
Closes OSIDB-2818
Closes OSIDB-3076
Closes OSIDB-2789
Closes OSIDB-3022
Closes OSIDB-3250