Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSIDB-3805] Show Flaw Labels on Issue List #522

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Conversation

MrMarble
Copy link
Member

@MrMarble MrMarble commented Jan 9, 2025

[OSIDB-3805] Show Flaw Labels on Issue List

Checklist:

  • Commits consolidated
  • Changelog updated
  • Test cases added/updated
  • Jira ticket updated

Summary:

image

The color is defined by the state of the label, REQ state will by highlighted, as of now, there are only 16 labels, so there should be enough space on the table to show all in case a flaw has a lot of labels (not common)

Changes:

  • Replaced scroll handler with intersectionObserver to load more flaws on scroll to improve performance
  • Updated vueuse/core and vue packages to latest version to improve performance and fix an issue with useElementVisibility composable
  • Reduced the container height to remove the double scroll bar on issue list
  • Fixed horizontal scroll on IndexView due to a left margin
  • Fixed invalid html warning on tests

Considerations:

Closes OSIDB-3805

@MrMarble MrMarble self-assigned this Jan 9, 2025
@MrMarble MrMarble force-pushed the feature/OSIDB-3805 branch 2 times, most recently from 92b9771 to 4e22ac8 Compare January 9, 2025 14:49
@MrMarble MrMarble marked this pull request as ready for review January 9, 2025 14:50
superbuggy
superbuggy previously approved these changes Jan 9, 2025
C-Valen
C-Valen previously approved these changes Jan 9, 2025
@MrMarble MrMarble dismissed stale reviews from C-Valen and superbuggy via f90c611 January 9, 2025 16:11
@MrMarble MrMarble force-pushed the feature/OSIDB-3805 branch 4 times, most recently from 188a8d9 to 110b057 Compare January 14, 2025 13:01
C-Valen
C-Valen previously approved these changes Jan 14, 2025
@MrMarble MrMarble force-pushed the feature/OSIDB-3805 branch 2 times, most recently from 806c989 to e2bec03 Compare January 14, 2025 14:43
C-Valen
C-Valen previously approved these changes Jan 14, 2025
C-Valen
C-Valen previously approved these changes Jan 14, 2025
superbuggy
superbuggy previously approved these changes Jan 14, 2025
@MrMarble MrMarble dismissed stale reviews from superbuggy and C-Valen via 385ebbf January 14, 2025 16:03
@MrMarble MrMarble merged commit 67c0a40 into main Jan 14, 2025
5 checks passed
@MrMarble MrMarble deleted the feature/OSIDB-3805 branch January 14, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants