-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Directionality #120
Conversation
…orithms in master
Update Summary.py For Mixed Graphs #128 |
Now that we can support mixed graphs, I can update the EGFR example network to the original version that included directed and undirected edges. I'll need to adjust the edge weight that was greater than 1 again. The file came from https://raw.githubusercontent.com/koksal/tps/master/data/networks/phosphosite-irefindex13.0-uniprot.txt |
I merged the Cytoscape changes and resolved merge conflicts in 39b4748. We can extend Cytoscape to support the U and D edge types in the pull request and then update the image to v2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I continued reviewing and made it through all of the source files under the spras
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished reviewing the rest of the files in the pull request.
test/analysis/input/example/data0-meo-params-GKEDDFZ_pathway.txt
Outdated
Show resolved
Hide resolved
test/analysis/input/example/data1-meo-params-GKEDDFZ_pathway.txt
Outdated
Show resolved
Hide resolved
I ran the algorithms with the EGFR test data as a final test, which nicely illustrates outputs on a mixed graph. That revealed some problems with self-edges in the dataset that MEO couldn't handle, so I removed them. I also noticed the edge direction support in Cytoscape wasn't working yet, so I rebuilt and pushed the updated Docker image. That didn't fix the problem: b4d6e1c contains changes from my final proofreading and formatting. If the tests pass, I'll merge. |
Closes #107