-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to HTTP.jl 1.0 #6
Conversation
0d1b846
to
ae0e41b
Compare
@dewilson could you approve the workflow run? Also, how much do the tests actually exercise HTTP.jl? I.e. if there was a type error, would the tests catch it? 😬 |
Pull Request Test Coverage Report for Build 2677537670
💛 - Coveralls |
Project.toml
Outdated
@@ -11,5 +11,4 @@ Sockets = "6462fe0b-24de-5631-8697-dd941f90decc" | |||
|
|||
[compat] | |||
julia="^1.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're going to drop the julia 1.6 tests, i guess you should also bump the required julia to 1.7 or later?
Otherwise we should probably be testing on the versions we want to support, and the usual way people do that is they test on all three of (oldest supported version, current official release, julia master)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not honestly sure why 1.6 didn't work… it said a manifest (this package? a dependency?) was generated with a different version… wasn't sure how to fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Nathan Daly <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks pete
thanks for the review Nathan! I don't have repo access yet (https://github.com/RelationalAI/it-ops/issues/599) — Dana can you merge? I'll then make a release |
Co-authored-by: Nathan Daly <[email protected]>
Fixes #5
cc @dewilson