Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to HTTP.jl 1.0 #6

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Conversation

vilterp
Copy link
Collaborator

@vilterp vilterp commented Jul 14, 2022

Fixes #5

cc @dewilson

@vilterp vilterp force-pushed the pv-upgrade-http-jl branch from 0d1b846 to ae0e41b Compare July 15, 2022 05:11
@vilterp
Copy link
Collaborator Author

vilterp commented Jul 15, 2022

@dewilson could you approve the workflow run?

Also, how much do the tests actually exercise HTTP.jl? I.e. if there was a type error, would the tests catch it? 😬

@coveralls
Copy link

coveralls commented Jul 15, 2022

Pull Request Test Coverage Report for Build 2677537670

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 87.333%

Files with Coverage Reduction New Missed Lines %
src/threading-utils.jl 1 56.41%
Totals Coverage Status
Change from base Build 2673663596: -0.04%
Covered Lines: 262
Relevant Lines: 300

💛 - Coveralls

Project.toml Outdated
@@ -11,5 +11,4 @@ Sockets = "6462fe0b-24de-5631-8697-dd941f90decc"

[compat]
julia="^1.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to drop the julia 1.6 tests, i guess you should also bump the required julia to 1.7 or later?

Otherwise we should probably be testing on the versions we want to support, and the usual way people do that is they test on all three of (oldest supported version, current official release, julia master)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not honestly sure why 1.6 didn't work… it said a manifest (this package? a dependency?) was generated with a different version… wasn't sure how to fix this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project.toml Show resolved Hide resolved
@vilterp vilterp requested a review from NHDaly July 15, 2022 17:09
.github/workflows/CI.yml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks pete

@vilterp
Copy link
Collaborator Author

vilterp commented Jul 15, 2022

thanks for the review Nathan! I don't have repo access yet (https://github.com/RelationalAI/it-ops/issues/599) — Dana can you merge?

I'll then make a release

Co-authored-by: Nathan Daly <[email protected]>
@dewilson dewilson merged commit 848ba9b into RelationalAI-oss:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to HTTP.jl 1.0
4 participants