Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule for Initialization + cleaning #103

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

bergel
Copy link
Collaborator

@bergel bergel commented Oct 28, 2024

No description provided.

Copy link

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-10-28T13:45:59.580)

  • Line 619, column 9: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/src/interface.jl
  • Line 625, column 13: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/src/interface.jl
  • Line 63, column 12: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 176, column 27: Functions must not be used to initialize a constant variable. raicode/src/interface.jl
  • Line 233, column 12: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 446, column 5: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 58, column 43: Use $(x) instead of $x (explanation). raicode/src/linting/extended_checks.jl
  • Line 222, column 33: Functions must not be used to initialize a constant variable. raicode/src/linting/extended_checks.jl
  • Line 223, column 5: Functions must not be used to initialize a constant variable. raicode/src/linting/extended_checks.jl
  • Line 224, column 9: Functions must not be used to initialize a constant variable. raicode/src/linting/extended_checks.jl
  • Line 225, column 9: Functions must not be used to initialize a constant variable. raicode/src/linting/extended_checks.jl
  • Line 226, column 9: Functions must not be used to initialize a constant variable. raicode/src/linting/extended_checks.jl
  • Line 231, column 21: Functions must not be used to initialize a constant variable. raicode/src/linting/extended_checks.jl
  • Line 293, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 347, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 350, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 351, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 391, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 487, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 499, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 532, column 26: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 31, column 16: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 43, column 16: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 982, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1038, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1099, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1282, column 21: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
    🚨In total, 19 rule violations and 0 PR reviewer recommendation are found over 3 Julia files🚨

@bergel bergel merged commit 51c08a0 into main Oct 28, 2024
7 checks passed
bergel added a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant