Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved checks on string interpolation #72

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

bergel
Copy link
Collaborator

@bergel bergel commented Aug 7, 2024

Finally got the behavior we wanted.

Copy link

github-actions bot commented Aug 7, 2024

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-08-07T09:31:52.991)

  • Line 54, column 43: Suspicious string interpolation, use $(x) instead of $x. raicode/src/linting/extended_checks.jl
  • Line 249, column 5: It is preferable to use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 292, column 13: It is preferable to use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 323, column 5: It is preferable to use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 377, column 5: It is preferable to use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 380, column 5: It is preferable to use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 381, column 5: It is preferable to use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 421, column 5: It is preferable to use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 518, column 5: It is preferable to use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 530, column 5: It is preferable to use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
    🚨In total, 10 rule violations and 0 PR reviewer recommendation are found over 2 Julia files🚨

@bergel bergel merged commit 2fe8eb0 into main Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant