Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation prohibited outside @safe #79

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

bergel
Copy link
Collaborator

@bergel bergel commented Sep 24, 2024

Copy link

github-actions bot commented Sep 24, 2024

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-12-03T10:02:52.683)

  • Line 58, column 43: Use $(x) instead of $x (explanation). raicode/src/linting/extended_checks.jl
  • Line 266, column 47: Log messages must always be constructed via @safe("..") strings. If this interpolation is used in a log message, it should be a @safe-string. Please try this instead: @safe("...$(x)..."). If this is not being used for logging, you can lint-ignore this line.
    raicode/src/linting/extended_checks.jl
  • Line 295, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 351, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 354, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 355, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 395, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 491, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 503, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 538, column 26: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 603, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 31, column 16: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 43, column 16: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 991, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1047, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1108, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1291, column 21: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
    🚨In total, 11 rule violations and 0 PR reviewer recommendation are found over 2 Julia files🚨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant