Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FrontCompiler to allowed users of Shape #80

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

mmcgr
Copy link
Contributor

@mmcgr mmcgr commented Sep 27, 2024

Add FrontCompiler to allowed users of Shape. Remove Compiler/Front and Compiler/front2back.jl.

Dependent on the move to FrontCompiler: https://github.com/RelationalAI/raicode/pull/21115/

@mmcgr mmcgr requested a review from azreika September 27, 2024 05:22
Copy link

github-actions bot commented Sep 27, 2024

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-09-27T06:51:43.725)

  • Line 58, column 43: Use $(x) instead of $x (explanation). raicode/src/linting/extended_checks.jl
  • Line 271, column 5: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 314, column 13: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 346, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 400, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 403, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 404, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 444, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 541, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 553, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
    🚨In total, 10 rule violations and 0 PR reviewer recommendation are found over 2 Julia files🚨

Copy link
Contributor

@gkastrinis gkastrinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gkastrinis gkastrinis merged commit a0e10ed into main Sep 27, 2024
7 checks passed
@gkastrinis gkastrinis deleted the mm-frontcompiler-shape branch September 27, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants