Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usages of Shape under packages #83

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

gkastrinis
Copy link
Contributor

Allow Shape to appear under packages because metadata.proto also defines a concept called Shape.

@gkastrinis gkastrinis requested a review from bergel October 8, 2024 15:07
Copy link

github-actions bot commented Oct 8, 2024

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-10-08T15:08:39.254)

  • Line 58, column 43: Use $(x) instead of $x (explanation). raicode/src/linting/extended_checks.jl
  • Line 271, column 5: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 314, column 13: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 346, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 400, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 403, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 404, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 444, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 541, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 553, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
    🚨In total, 10 rule violations and 0 PR reviewer recommendation are found over 1 Julia file🚨

@gkastrinis gkastrinis merged commit 9ebcd77 into main Oct 10, 2024
7 checks passed
@gkastrinis gkastrinis deleted the gka-allow-shape-in-packages branch October 10, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant