Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML column on comments for storing tiptap editor data #2091

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

HTML column on comments for storing tiptap editor data #2091

wants to merge 3 commits into from

Conversation

yattias
Copy link
Contributor

@yattias yattias commented Feb 3, 2025 •
edited
Loading

  • To support tiptap, we need to introduce a new html property
  • For backwards compatibility, we will still support comment_content_json

@yattias yattias requested a review from a team as a code owner February 3, 2025 03:00
@yattias yattias changed the title adding html comment prop HTML column on comments for storing tiptap editor data Feb 3, 2025
gzurowski
gzurowski approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@gzurowski gzurowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzurowski gzurowski gzurowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yattias @gzurowski