Code smell/missing asserts

RetGal · Feb 21, 2021 · 6119208 · 6119208
1 parent 86393fd
commit 6119208
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/main/java/mpo/dayon/assisted/control/RobotNetworkControlMessageHandler.java b/src/main/java/mpo/dayon/assisted/control/RobotNetworkControlMessageHandler.java
@@ -99,7 +99,6 @@ private void pressKey(NetworkKeyControlMessage message) {
 				if (key.getKeyCode() != Character.MIN_VALUE) {
 					Log.warn("retrying with keyCode " + key.getKeyCode());
 					typeUnicode(key.getKeyCode());
-					return;
 				}
 				shout(message.getKeyChar());
 			}
@@ -122,7 +121,6 @@ private void releaseKey(NetworkKeyControlMessage message) {
 				KeyStroke key = KeyStroke.getKeyStroke(message.getKeyChar(), 0);
 				if (key.getKeyCode() != Character.MIN_VALUE) {
 					releaseUnicode();
-					return;
 				}
 			}
 		}

diff --git a/src/test/java/mpo/dayon/assisted/control/RobotNetworkControlMessageHandlerTest.java b/src/test/java/mpo/dayon/assisted/control/RobotNetworkControlMessageHandlerTest.java
@@ -67,8 +67,8 @@ void testHandleMessageReleaseTurkishLowerSpecialSTypedOnNonTurkishAssisted() {
         // when
         controlMessageHandler.handleMessage(message);
         // then
-        robot.keyRelease(KeyEvent.VK_SHIFT);
-        robot.keyRelease(KeyEvent.VK_CONTROL);
+        verify(robot).keyRelease(KeyEvent.VK_SHIFT);
+        verify(robot).keyRelease(KeyEvent.VK_CONTROL);
     }
 
     @Test
@@ -100,7 +100,7 @@ void testHandleMessageReleaseTurkishUpperSpecialSTypedOnNonTurkishAssisted() {
         // when
         controlMessageHandler.handleMessage(message);
         // then
-        robot.keyRelease(KeyEvent.VK_SHIFT);
-        robot.keyRelease(KeyEvent.VK_CONTROL);
+        verify(robot).keyRelease(KeyEvent.VK_SHIFT);
+        verify(robot).keyRelease(KeyEvent.VK_CONTROL);
     }
 }