Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow weighting event achievements #3152

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jan 30, 2025

Allows assigning a point value to an event achievement (1-5 [1=default]). Changes the wording for tiered achievements from "achievements required" to "points required".

SQL to run after upgrade:

UPDATE Achievements SET Points=1 WHERE ID IN (SELECT achievement_id FROM event_achievements);

Then the following command should be run to regenerate the aggregate data for the event games:

sail artisan ra:platform:game:update-metrics 28429,29830,31745,32718,32827,32828,32829,32830,32831,32832,32833,32834,32835,32836,32838,32847,32907,32908

@Jamiras Jamiras added deployment/sql Includes SQL that needs to be run before/after deployment deployment/command Includes an Artisan command that needs to be run before/during deployment labels Jan 30, 2025
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this component still does display RetroPoints:
Screenshot 2025-01-30 at 5 31 56 PM

I'm in favor of not touching this though. We can fix it in the React migration.

@Jamiras
Copy link
Member Author

Jamiras commented Jan 30, 2025

I've updated it to not display the true points if they're 0 (I did the same thing for the achievement list item).

I've also updated the order of the event-specific processing so it occurs after the point totals are tallied so we can explicitly zero out the total true points.

With the React conversion we should hide the achievement progress if it matches the point total (or maybe always?).

@televandalist
Copy link
Member

Nice. I was wondering if there would be something like this. I'm planning something where it would definitely get utilized. 😏

@Jamiras Jamiras merged commit d62620a into RetroAchievements:master Jan 31, 2025
8 checks passed
@Jamiras Jamiras deleted the feature/event_points branch January 31, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment/command Includes an Artisan command that needs to be run before/during deployment deployment/sql Includes SQL that needs to be run before/after deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants