-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPi Intergration #37
base: master
Are you sure you want to change the base?
Conversation
Update to work with PyPI Fix pipeline Update pipeline Update pipeline Update pipeline
# Versions should comply with PEP440. For a discussion on single-sourcing | ||
# the version across setup.py and the project code, see | ||
# https://packaging.python.org/en/latest/single_source_version.html | ||
name='semver-by-branch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need to change the package name, that only has to be updated here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good but the jenkins file doesnt look like it'll work, if it builds currently it may be because of prior builds having artifacts left around
PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library
27879ae
to
34f58b7
Compare
sh "python setup.py sdist" | ||
|
||
stash includes: "dist/semver-${env.SEMVER_NEW_VERSION}.tar.gz", name: 'PACKAGE' | ||
script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont need script here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required for dockerImage
and docker.build
docker push rightbrainnetworks/auto-semver:${env.VERSION} | ||
""") | ||
sh("docker login -u ${DOCKER_USERNAME} -p ${DOCKER_PASSWORD}") | ||
script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont need script here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required for dockerImage
object
0be2ad4
to
c414515
Compare
As a note, I tried removing the some of the |
The
setup.py
file was updated to use the package namesemver-by-branch
. The metadata was also updated to work with PyPi.The
Release
stage was split into theRelease Packages
stage andPush Docker Image
stage. TheRelease Packages Stage
pushes packages to GitHub & PyPi while thePush Docker Image
stage pushes thelatest
tag to DockerHub.README.md
The
README.md
file was updated to reflect installation using pip from PyPi.