Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sitemap for images to resolve indexing issues with webp images #1389

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

samnixon87
Copy link
Contributor

NB: May increase build time

@samnixon87 samnixon87 requested a review from a team September 19, 2024 11:40
@samnixon87 samnixon87 marked this pull request as draft September 19, 2024 11:42
gatsby-config.js Outdated
@@ -209,7 +209,34 @@ module.exports = {
{
resolve: 'gatsby-plugin-sitemap',
options: {
output: `/sitemap-index`,
excludes: DISLALLOW_LIST,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw this. Can you rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik it should match the other sitemaps, which are currently only on sitemap-index. sitemap-index should collect all sitemaps though, so I'll change and see what happens

Copy link
Contributor

@Xantier Xantier Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant the typo here. DIESEL-ALLOW

Copy link
Contributor Author

@samnixon87 samnixon87 Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A DT var that I didn't catch. Changed

@samnixon87 samnixon87 marked this pull request as ready for review September 20, 2024 15:13
@dtuite
Copy link
Member

dtuite commented Sep 20, 2024

Test this against the roadie.io/sitemap-0.xml sitemap please. We need to be sure we don't actually deindex a bunch of pages or something like that.

Copy link

sonarcloud bot commented Oct 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants