Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move most of the plugins to new backend system #1304

Closed
wants to merge 1 commit into from

Conversation

drodil
Copy link

@drodil drodil commented Mar 26, 2024

Closes #1294

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

@drodil drodil requested review from karlhaworth and a team as code owners March 26, 2024 09:25
@kissmikijr
Copy link
Contributor

Do we need a version upgrade to 1.24 as well to support the backend system ? or not much changes and makes sense to do it together? It looks like a lot of code changes right now and not sure what related to what exactly :D

@drodil
Copy link
Author

drodil commented Mar 26, 2024

Yes we do as for example the scaffolder mock action context is not available earlier. Also some exports missing from backstage/backend-plugin-api before 1.24.

@drodil
Copy link
Author

drodil commented Mar 26, 2024

And yes, it's quite a big change and doesn't include even all of the plugins. So some work still required.

@@ -0,0 +1,41 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of our plugins are past 1.x so there should be some minor bumps in here

Copy link
Contributor

github-actions bot commented Apr 2, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 2, 2024
@kissmikijr
Copy link
Contributor

bumped the plugin's versions to the backstage version 1.25.0 so this PR shouldn't to handle that anymore

@punkle
Copy link
Contributor

punkle commented Apr 5, 2024

@drodil this is great work. I am just realizing that I may have stood on your toes with the backend integration for the rag-ai-backend yesterday. Sorry about that, I had intended to get a feel for the process and didn't realise you had actually started the work.

What can we do to help you get this merged?

@drodil
Copy link
Author

drodil commented Apr 5, 2024

Probably should abandon this and do the migration one plugin at a time. Otherwise it's just too much 😅

@punkle
Copy link
Contributor

punkle commented Apr 5, 2024

@drodil sounds like a good plan!

@punkle
Copy link
Contributor

punkle commented Apr 5, 2024

@drodil I had an idea that we could create an issue listing all of the plugins that need migrating as tasks and then take owners for the migration of each plugin one by one. What do you think?

@drodil
Copy link
Author

drodil commented Apr 5, 2024

@punkle sounds like a good idea!

@drodil
Copy link
Author

drodil commented Apr 5, 2024

This PR could be used as an example/reference for the migration. But I will close this now.

@drodil drodil closed this Apr 5, 2024
@hairmare
Copy link

hairmare commented Apr 6, 2024

👉 #1325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support the new backend system for http-scaffolder-plugin
5 participants