roaring64: container_remove_range returns null rather than returning an empty container #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Emann
changed the title
SLieve
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Thanks for finding it and for the fix! I saw in RoaringBitmap/croaring-rs#125 that you found most of these bugs with fuzzing, that's really cool :)
|
The CI failure seems like it shouldn't be caused by my change, going to rebase to rerun the CI. |
…ntainer This could lead to an assert in `container_nonzero_cardinality`: typecode2 was never set, so it was unlikely to be one of the known typecodes
Dr-Emann
force-pushed
the
push-rylnkxznopku
branch
from
3e586f4
to
1b7ab5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would lead to all sorts of issues:
typecode2is read uninitialized, and hopefully just asserts that it's not one of the known typecodes. Then, we've stored a null container into the bitmap.