Add From<Bitmap> for Bitmap64 (#157)

Use new roaring64_bitmap_move_from_roaring32 function
RoaringBitmap · Sep 20, 2024 · 7716f57 · 7716f57
2 parents 5c85403 + 0bcef52
commit 7716f57
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 8 deletions.
diff --git a/croaring/Cargo.toml b/croaring/Cargo.toml
@@ -25,7 +25,7 @@ roaring = "0.10"
 criterion = { version = "0.5", features = ["html_reports"] }
 
 [dependencies]
-ffi = { package = "croaring-sys", path = "../croaring-sys", version = "~4.1.1" }
+ffi = { package = "croaring-sys", path = "../croaring-sys", version = "~4.1.4" }
 
 [[bench]]
 name = "benches"

diff --git a/croaring/src/bitmap/mod.rs b/croaring/src/bitmap/mod.rs
@@ -67,7 +67,7 @@ use core::marker::PhantomData;
 // &BitmapView and &Bitmap
 #[repr(transparent)]
 pub struct Bitmap {
-    bitmap: ffi::roaring_bitmap_t,
+    pub(crate) bitmap: ffi::roaring_bitmap_t,
 }
 
 unsafe impl Sync for Bitmap {}

diff --git a/croaring/src/bitmap64/ops.rs b/croaring/src/bitmap64/ops.rs
@@ -1,4 +1,4 @@
-use crate::Bitmap64;
+use crate::{Bitmap, Bitmap64};
 use core::fmt;
 use core::ops::{BitAnd, BitAndAssign, BitOr, BitOrAssign, BitXor, BitXorAssign, Sub, SubAssign};
 use ffi::roaring64_bitmap_copy;
@@ -45,6 +45,12 @@ impl From<&'_ [u64]> for Bitmap64 {
     }
 }
 
+impl From<Bitmap> for Bitmap64 {
+    fn from(mut value: Bitmap) -> Self {
+        unsafe { Self::take_heap(ffi::roaring64_bitmap_move_from_roaring32(&mut value.bitmap)) }
+    }
+}
+
 impl<const N: usize> From<[u64; N]> for Bitmap64 {
     #[inline]
     #[doc(alias = "roaring64_bitmap_of_ptr")]

diff --git a/fuzz/Cargo.lock b/fuzz/Cargo.lock
diff --git a/fuzz/fuzz_targets/deserialize.rs b/fuzz/fuzz_targets/deserialize.rs
@@ -2,6 +2,7 @@
 
 use croaring::{Bitmap, Bitmap64, Native, Portable};
 use libfuzzer_sys::fuzz_target;
+use libfuzzer_sys::arbitrary::{self, Arbitrary};
 
 fn check_bitmap<D: croaring::bitmap::Deserializer>(input: &[u8]) {
     let bitmap = Bitmap::try_deserialize::<D>(input);
@@ -63,8 +64,18 @@ fn check_bitmap64<D: croaring::bitmap64::Deserializer>(input: &[u8]) {
     }
 }
 
-fuzz_target!(|input: &[u8]| {
-    check_bitmap::<Portable>(input);
-    check_bitmap::<Native>(input);
-    check_bitmap64::<Portable>(input);
+#[derive(Arbitrary, Debug)]
+enum BitmapType {
+    Portable32,
+    Native32,
+    Portable64,
+}
+
+fuzz_target!(|input: (BitmapType, &[u8])| {
+    let (ty, input) = input;
+    match ty {
+        BitmapType::Portable32 => check_bitmap::<Portable>(input),
+        BitmapType::Native32 => check_bitmap::<Native>(input),
+        BitmapType::Portable64 => check_bitmap64::<Portable>(input),
+    }
 });