Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG windows docker build #537

Conversation

jacobdr
Copy link
Contributor

@jacobdr jacobdr commented Oct 29, 2022

Change Summary

Please summarise the changes this pull request is making here.

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

rhoboro and others added 6 commits October 23, 2022 09:07
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…e#533)

Bumps [slotscheck](https://github.com/ariebovenberg/slotscheck) from 0.14.0 to 0.15.0.
- [Release notes](https://github.com/ariebovenberg/slotscheck/releases)
- [Changelog](https://github.com/ariebovenberg/slotscheck/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/ariebovenberg/slotscheck/commits)

---
updated-dependencies:
- dependency-name: slotscheck
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ts (RobertCraigie#535)

* chore(deps): bump syrupy from 1.5.0 to 3.0.2 in /pipelines/requirements

Bumps [syrupy](https://github.com/tophat/syrupy) from 1.5.0 to 3.0.2.
- [Release notes](https://github.com/tophat/syrupy/releases)
- [Changelog](https://github.com/tophat/syrupy/blob/master/CHANGELOG.md)
- [Commits](syrupy-project/syrupy@v1.5.0...v3.0.2)

---
updated-dependencies:
- dependency-name: syrupy
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update snapshots per syrupy breaking change

syrupy-project/syrupy#505

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Robert Craigie <[email protected]>
)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jacobdr jacobdr changed the title DEBUG windows build DEBUG windows docker build Oct 29, 2022
@jacobdr jacobdr force-pushed the refactor/remove-pkg-cli-jdr branch 17 times, most recently from 49be3a3 to 333dc77 Compare October 29, 2022 19:21
@jacobdr jacobdr changed the base branch from main to refactor/remove-pkg-cli October 29, 2022 19:21
@jacobdr jacobdr force-pushed the refactor/remove-pkg-cli-jdr branch 4 times, most recently from 5f2ea4c to 7876727 Compare October 29, 2022 20:00
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 93.70% // Head: 93.70% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (778a54b) compared to base (010bb8c).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           refactor/remove-pkg-cli     #537   +/-   ##
========================================================
  Coverage                    93.70%   93.70%           
========================================================
  Files                          115      115           
  Lines                         6118     6120    +2     
  Branches                      1059     1008   -51     
========================================================
+ Hits                          5733     5735    +2     
  Misses                         326      326           
  Partials                        59       59           
Impacted Files Coverage Δ
src/prisma/mypy.py 0.00% <0.00%> (ø)
src/prisma/cli/_node.py 86.82% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jacobdr jacobdr closed this Nov 5, 2022
@jacobdr
Copy link
Contributor Author

jacobdr commented Nov 5, 2022

As discussed on Slack offline, the windows issue is somewhat known...

docker-library/python#359

Relevant discussion from the Python email list:

Note that in our first attempt there were only 12 root cacerts in the Windows certstore. Now it's 15. And the only difference is that in between we've made an SCHANNEL-based https connection to the google.de domain. (You can also see the additional root certificates via the certificates mmc consoles certlm.msc and certmgr.msc).

From now on all non-SCHANNEL based HTTPS connections via the Python 2/3 ssl standard lib work, as SCHANNEL has permanently placed the RootCA cert in the windows certstore:


c:\python27\python.exe
Python 2.7.15 (v2.7.15:ca079a3ea3, Apr 30 2018, 16:30:26) [MSC v.1500 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import socket, ssl
>>> context = ssl.SSLContext(ssl.PROTOCOL_TLS)
>>> context.verify_mode = ssl.CERT_REQUIRED
>>> context.check_hostname = True
>>> context.load_default_certs()
>>> s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
>>> ssl_sock = context.wrap_socket(s, server_hostname='www.google.de')
# got a certificate verify failed error here in the first try, this time the verify is successfull
>>> ssl_sock.connect(('www.google.de', 443))
>>> ssl_sock.close()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants