Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Everyone should Score + Partial Scoring #843

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

hawkina
Copy link
Contributor

@hawkina hawkina commented Jan 10, 2024

** Note: Your contribution is expected to meet the conventions and policies described in the contribution guidelines **

Description

An attempt to tackle the issues of "Teams should score" and "Partial Points". The changes mostly concern Stage 1 points, in order to give newcomers a chance of scoring, while also giving bonus points for completing (sub) tasks, in order to encourage trying to solve the entire task and not just farm partial points. We kept the Stage 2 grading almost as it was, since the generic way of how the task rewards are phrased, is fitting for the advanced challenges.
Mostly the approach contains splitting up actions into partial steps to allow giving points for perception or picking up of objects, so that teams can still get points even if something goes wrong during e.g. placing.
The total points of the tasks do not total to round numbers - but it was decided to disregard this for now.

PDF for ease of view: rulebook.pdf

Closes issue #
#804 - Teams should score
#808 - Partial Scoring

Changes proposed in this pull request:

  • give points for completing parts of the challenges
  • give bonus points for completing the entire task to encourage task completion
  • points farming (e.g. just picking up objects and dropping them again) is not allowed

Other comments

If this request is marked as a draft, please describe your plans or any specific feedback you would like

@MatthijsBurgh
Copy link
Collaborator

Thanks for creating a new clean PR.

@@ -9,7 +9,8 @@
\scoreitem[2]{100}{Detect calling or waving customer}
\scoreitem[2]{100}{Reach a customer's table without prior guidance/training}

\scoreitem[2]{600}{Take and serve an order.}
\scoreitem[2]{300}{Take and serve an order.}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "take an order"? since now serve an order is in there twice

@@ -2,14 +2,21 @@

\begin{scorelist}
\scoreheading{Main Goal}
\scoreitem[5]{60}{Picking tableware and cutlery for transportation to the dishwasher}
\scoreitem[5]{180}{Placing the tableware and cutlery inside the dishwasher}
\scoreitem{15}{Navigate to the table to pick up items}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be scored? It is very simple for a stage 2 challenge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we decided it is fine to award small amounts of points for things like this. It motivates teams and also differentiates teams that enter and attempt the test from teams that don't attempt the test at all.

\scoreitem[4]{15}{Perceiving object and categorizing it correctly (visualize or say)}
\scoreitem[4]{30}{Picking up breakfast items for transportation to the table}
\scoreitem[4]{30}{Placing breakfast items on the table}
\scoreitem{100}{Pouring cereal into the bowl}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we reduce the amount of points for pouring? This is still very challenging for many teams. I think 300 pts is appropriate for such a challenging task.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I would leave it at 300 and maybe increase the penalty for spilling? Because pouring without spilling is still very challenging but just pouring can be potentially done closed loop.
Also maybe add the entire package must be poured or add penalty for not pouring entire contents.
Same comments go for the milk pouring in bonus section.

\scoreitem{50}{Avoiding the crowd of people obstructing the path}
\scoreitem{50}{Avoiding the small object on the ground}
\scoreitem{50}{Avoiding the hard-to-see object}
\scoreitem{50}{Avoiding the area blocked with retractable barriers}

\scoreheading{Bonus rewards}
\scoreitem{300}{Successful task completion}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean? is is to accomplish all the main goal items?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Basically if all sub-tasks are completed, one gets bonus points in order to encourage teams to try and complete the entire task instead of going for solving as many sub-tasks as possible.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quoting johannes: does this include completing the main goal using deus ex machina? please clarify.
perhaps move this to main goals.
suggestion: give these points for a team solving all main goals without using deus ex machina.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, bonus points are intended to be for difficult challenges not otherwise required in the stage. Like for carry my luggage: navigating without a map and queuing.
I would remove the Successful task completion items entirely and move the points back to their individual scoring items

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quote Rulebook: "Bonuses: No bonus points can be scored when the robot requests help to solve part of a
task that normally would grant a bonus."
-> So then the Bonus points for task completion wouldn't have been awarded either in my understanding
-> removed it anyway due to the proposed suggestion

@johaq johaq self-requested a review February 26, 2024 12:11
@sunava sunava self-requested a review February 26, 2024 12:11
\scoreitem{50}{Avoiding the crowd of people obstructing the path}
\scoreitem{50}{Avoiding the small object on the ground}
\scoreitem{50}{Avoiding the hard-to-see object}
\scoreitem{50}{Avoiding the area blocked with retractable barriers}

\scoreheading{Bonus rewards}
\scoreitem{300}{Successful task completion}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, bonus points are intended to be for difficult challenges not otherwise required in the stage. Like for carry my luggage: navigating without a map and queuing.
I would remove the Successful task completion items entirely and move the points back to their individual scoring items

@@ -2,14 +2,21 @@

\begin{scorelist}
\scoreheading{Main Goal}
\scoreitem[5]{60}{Picking tableware and cutlery for transportation to the dishwasher}
\scoreitem[5]{180}{Placing the tableware and cutlery inside the dishwasher}
\scoreitem{15}{Navigate to the table to pick up items}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we decided it is fine to award small amounts of points for things like this. It motivates teams and also differentiates teams that enter and attempt the test from teams that don't attempt the test at all.

scoresheets/CleanTable.tex Outdated Show resolved Hide resolved
\scoreitem[4]{15}{Perceiving object and categorizing it correctly (visualize or say)}
\scoreitem[4]{30}{Picking up breakfast items for transportation to the table}
\scoreitem[4]{30}{Placing breakfast items on the table}
\scoreitem{100}{Pouring cereal into the bowl}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I would leave it at 300 and maybe increase the penalty for spilling? Because pouring without spilling is still very challenging but just pouring can be potentially done closed loop.
Also maybe add the entire package must be poured or add penalty for not pouring entire contents.
Same comments go for the milk pouring in bonus section.

scoresheets/StoringGroceries.tex Outdated Show resolved Hide resolved
@hawkina
Copy link
Contributor Author

hawkina commented Mar 4, 2024

Adapted to requested changes. Moved back bonus points for task completion to the sub tasks of the main challenges.

@hawkina hawkina merged commit b745397 into RoboCupAtHome:master Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants