Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planner mutex lock #2144

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Planner mutex lock #2144

merged 9 commits into from
Nov 14, 2023

Conversation

petergarud
Copy link
Contributor

Description

Describe your pull request.

Associated / Resolved Issue

Resolves # or ClickUp card

Design Documents

Link

Steps to Test

Test Case 1

  1. Step 1
  2. Step 2
  3. Step 3

Expected result:???

Key Files to Review

Group 1

  • File 1
  • File 2

Group 2

  • File 3
  • File 4

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

Copy link
Contributor

@sid-parikh sid-parikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, exactly what I was looking for

@sid-parikh sid-parikh merged commit d8ebe43 into ros2 Nov 14, 2023
@sid-parikh sid-parikh deleted the planner-mutex-lock branch November 14, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants