Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic state management #2172

Closed
wants to merge 4 commits into from
Closed

Add dynamic state management #2172

wants to merge 4 commits into from

Conversation

rishiso
Copy link
Contributor

@rishiso rishiso commented Jan 29, 2024

Description

Implements position management automatically based on states of the game. Positions used to be static (3 defense, 2 offense, 1 goalie), but now they change dynamically.

Associated / Resolved Issue

ClickUp card

Steps to Test

Run in sim and move the ball to different halves. The positions of robots should change dynamically.

Key Files to Review

  • robot_factory_postion.cpp

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

jvogt23 and others added 4 commits January 23, 2024 12:09
Added hard-coded robot positions in main_window reset method
* added play state to plan request

* Fix style

* Fix Code Style On add-play-state-to-plan-request (#2166)

automated style fixes

Co-authored-by: sid-parikh <[email protected]>

---------

Co-authored-by: Sid Parikh <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sid-parikh <[email protected]>
* Removed unnecessary changes and added comments

* Rebased to ros2

* Fix Code Style On direct-pass (#2158)

automated style fixes

Co-authored-by: sanatd33 <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sanatd33 <[email protected]>
Co-authored-by: Sid Parikh <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: petergarud <[email protected]>
Co-authored-by: sid-parikh <[email protected]>
@rishiso rishiso closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants