Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Straight Line Testing Executable via Makefile #2327

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

N8BWert
Copy link
Contributor

@N8BWert N8BWert commented Jan 29, 2025

Description

This PR makes it significantly easier to run the straight line tests for robot movement. Basically, the PR creates a new node for running the straight line test and optionally disables the agent_action_client when running the straight line testing.

Steps to Test

Sim

  1. run make perf
  2. run make run-sim-line-test
  3. set the direction of the line via ros2 topic pub -1 line_direction std_msgs/msg/Bool "{data: VERTICAL}", where VERTICAL is True if you want the robots to move in a vertical line and False if you want the robots to move in a horizontal line.

Expected result: The simulated robots should move in a straight line

Real

  1. run make perf
  2. run make run-real-line-test
  3. set the direction of the line via ros2 topic pub -1 line_direction std_msgs/msg/Bool "{data: VERTICAL}", where VERTICAL is True if you want the robots to move in a vertical line and False if you want the robots to move in a horizontal line.

Expected result: The robots should move in a straight line

Key Files to Review

Group 1 StraightLineTest Node

  • soccer/src/soccer/strategy/agent/straight_line_test.*pp

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

@N8BWert N8BWert requested a review from jacksherling January 29, 2025 00:26
@N8BWert N8BWert merged commit 3d4490a into ros2 Jan 29, 2025
2 checks passed
@N8BWert N8BWert deleted the qualification-footage branch January 29, 2025 00:56
N8BWert added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants