Skip to content

Commit

Permalink
Added suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
roboteampc committed Aug 13, 2023
1 parent 8a915b5 commit 500d2db
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions roboteam_ai/src/world/World.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ constexpr double mmToM(double mm) {

void World::updateField(proto::SSL_GeometryFieldSize &protoField) {

// TODO Check if the new field actually differs? Maybe with google::protobuf::util::MessageDifferencer
// https://stackoverflow.com/questions/3228107/google-protocol-buffers-compare

// TODO: Move this conversion from the scary proto to the safe c++ rtt::Field type in observer or something.
// Observers' whole function is to filter and parse anyways, might as well check which proto fields are set and which arent...
// Also, the proto does not require penalty_area_depth to be set *UNLIKE GOAL DEPTH AND WIDTH*,
Expand Down

0 comments on commit 500d2db

Please sign in to comment.