-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script calling, reflection dump, test component #4
Conversation
Signed-off-by: Adam Dąbrowski <[email protected]>
Signed-off-by: Adam Dąbrowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minor comments.
Signed-off-by: Adam Dąbrowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot to digest here. Overall, it's a good PoC.
I have added some comments related to what is included in the headers - perhaps we could even use some auto tool like include-what-you-use for that.
Signed-off-by: Mateusz Żak <[email protected]>
Signed-off-by: Mateusz Żak <[email protected]>
966e00b
to
38b9cdf
Compare
Signed-off-by: Artur Kamieniecki <[email protected]>
38b9cdf
to
4c06cfa
Compare
All suggestions are now resolved, expect adding unit testing. |
Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Working code (to be refactor) allowing for calling and testing of behavior methods and ebuses through text prompts and script execution.
It is mostly in test / PoC status.