Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script calling, reflection dump, test component #4

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

adamdbrw
Copy link
Member

Working code (to be refactor) allowing for calling and testing of behavior methods and ebuses through text prompts and script execution.

It is mostly in test / PoC status.

Copy link
Contributor

@arturkamieniecki arturkamieniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comments.

Code/Source/Test/AICoreTest.h Outdated Show resolved Hide resolved
Code/Source/Tools/AICoreEditorModule.cpp Outdated Show resolved Hide resolved
Signed-off-by: Adam Dąbrowski <[email protected]>
Copy link
Member

@zakmat zakmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot to digest here. Overall, it's a good PoC.
I have added some comments related to what is included in the headers - perhaps we could even use some auto tool like include-what-you-use for that.

Code/Source/Test/AICoreTest.h Outdated Show resolved Hide resolved
Code/Source/AICoreModuleInterface.cpp Outdated Show resolved Hide resolved
Code/Source/Action/AICoreActionHandler.h Outdated Show resolved Hide resolved
Code/Source/Action/AICoreActionHandler.h Outdated Show resolved Hide resolved
Code/Source/Action/AICoreActionHandler.h Outdated Show resolved Hide resolved
Code/Source/Action/AICoreActionHandler.cpp Show resolved Hide resolved
Code/Source/Test/AICoreTest.h Show resolved Hide resolved
Code/Source/BehaviorContextUtils/BehaviorContextDump.cpp Outdated Show resolved Hide resolved
Code/Include/AICore/AICoreActionBus.h Show resolved Hide resolved
Code/Source/Action/AICoreActionHandler.cpp Outdated Show resolved Hide resolved
Code/Source/Action/AICoreActionRequestHandler.cpp Outdated Show resolved Hide resolved
Code/Source/Action/AICoreActionRequestHandler.cpp Outdated Show resolved Hide resolved
Code/Source/BehaviorContextUtils/BehaviorContextDump.cpp Outdated Show resolved Hide resolved
Code/Source/BehaviorContextUtils/BehaviorContextDump.cpp Outdated Show resolved Hide resolved
Code/Source/BehaviorContextUtils/BehaviorContextDump.cpp Outdated Show resolved Hide resolved
Code/Source/BehaviorContextUtils/BehaviorContextDump.h Outdated Show resolved Hide resolved
Code/Source/Test/AICoreTest.h Outdated Show resolved Hide resolved
Signed-off-by: Mateusz Żak <[email protected]>
@arturkamieniecki arturkamieniecki force-pushed the callable_reflection branch 5 times, most recently from 966e00b to 38b9cdf Compare February 20, 2024 12:12
Signed-off-by: Artur Kamieniecki <[email protected]>
@arturkamieniecki
Copy link
Contributor

All suggestions are now resolved, expect adding unit testing.

@adamdbrw adamdbrw merged commit f70e1d4 into main Feb 26, 2024
jhanca-robotecai added a commit that referenced this pull request Apr 10, 2024
jhanca-robotecai added a commit that referenced this pull request Apr 10, 2024
@jhanca-robotecai jhanca-robotecai deleted the callable_reflection branch April 10, 2024 10:34
jhanca-robotecai added a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants