Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct interface #30

Open
wants to merge 12 commits into
base: dashing
Choose a base branch
from
Open

Construct interface #30

wants to merge 12 commits into from

Conversation

mlanas
Copy link

@mlanas mlanas commented Apr 13, 2021

Topics implemented for the exoforce system to interface with the construct app.

@mlanas mlanas requested a review from missxa April 13, 2021 19:33
@mlanas mlanas self-assigned this Apr 13, 2021
Copy link
Contributor

@missxa missxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not ideal that the messages depend on each other, like middleware depends on simulation. can you avoid it?

@@ -14,6 +14,7 @@ find_package(ament_cmake REQUIRED)
find_package(rosidl_default_generators REQUIRED)
find_package(std_msgs REQUIRED)
find_package(geometry_msgs REQUIRED)
find_package(roboy_simulation_msgs REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, this is not ideal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move the LinkInformation msg from simulation to middleware, its only needed there

@mlanas mlanas requested a review from missxa April 18, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants