Minor refactoring of server vote handling

Avoid local references and nested assignment for readability when sending vote messages. Remove unnecessary temporary variable. Remove dead code.
Robyt3 · Dec 12, 2024 · 3058b1c · 3058b1c
1 parent 2ec51d7
commit 3058b1c
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/src/game/server/gamecontext.cpp b/src/game/server/gamecontext.cpp
@@ -814,30 +814,32 @@ void CGameContext::SendVoteSet(int ClientId)
 	{
 		Msg6.m_Timeout = Msg7.m_Timeout = (m_VoteCloseTime - time_get()) / time_freq();
 		Msg6.m_pDescription = m_aVoteDescription;
-		Msg7.m_pDescription = m_aSixupVoteDescription;
 		Msg6.m_pReason = Msg7.m_pReason = m_aVoteReason;
 
-		int &Type = (Msg7.m_Type = protocol7::VOTE_UNKNOWN);
+		Msg7.m_pDescription = m_aSixupVoteDescription;
 		if(IsKickVote())
-			Type = protocol7::VOTE_START_KICK;
+			Msg7.m_Type = protocol7::VOTE_START_KICK;
 		else if(IsSpecVote())
-			Type = protocol7::VOTE_START_SPEC;
+			Msg7.m_Type = protocol7::VOTE_START_SPEC;
 		else if(IsOptionVote())
-			Type = protocol7::VOTE_START_OP;
+			Msg7.m_Type = protocol7::VOTE_START_OP;
+		else
+			Msg7.m_Type = protocol7::VOTE_UNKNOWN;
 	}
 	else
 	{
 		Msg6.m_Timeout = Msg7.m_Timeout = 0;
 		Msg6.m_pDescription = Msg7.m_pDescription = "";
 		Msg6.m_pReason = Msg7.m_pReason = "";
 
-		int &Type = (Msg7.m_Type = protocol7::VOTE_UNKNOWN);
 		if(m_VoteEnforce == VOTE_ENFORCE_NO || m_VoteEnforce == VOTE_ENFORCE_NO_ADMIN)
-			Type = protocol7::VOTE_END_FAIL;
+			Msg7.m_Type = protocol7::VOTE_END_FAIL;
 		else if(m_VoteEnforce == VOTE_ENFORCE_YES || m_VoteEnforce == VOTE_ENFORCE_YES_ADMIN)
-			Type = protocol7::VOTE_END_PASS;
+			Msg7.m_Type = protocol7::VOTE_END_PASS;
 		else if(m_VoteEnforce == VOTE_ENFORCE_ABORT || m_VoteEnforce == VOTE_ENFORCE_CANCEL)
-			Type = protocol7::VOTE_END_ABORT;
+			Msg7.m_Type = protocol7::VOTE_END_ABORT;
+		else
+			Msg7.m_Type = protocol7::VOTE_UNKNOWN;
 
 		if(m_VoteEnforce == VOTE_ENFORCE_NO_ADMIN || m_VoteEnforce == VOTE_ENFORCE_YES_ADMIN)
 			Msg7.m_ClientId = -1;
@@ -1218,7 +1220,6 @@ void CGameContext::OnTick()
 				EndVote();
 				SendChat(-1, TEAM_ALL, "Vote failed enforced by authorized player", -1, FLAG_SIX);
 			}
-			//else if(m_VoteEnforce == VOTE_ENFORCE_NO || time_get() > m_VoteCloseTime)
 			else if(m_VoteEnforce == VOTE_ENFORCE_NO || (time_get() > m_VoteCloseTime && g_Config.m_SvVoteMajority))
 			{
 				EndVote();
@@ -2478,9 +2479,7 @@ void CGameContext::OnVoteNetMessage(const CNetMsg_Cl_Vote *pMsg, int ClientId)
 	if(g_Config.m_SvSpamprotection && pPlayer->m_LastVoteTry && pPlayer->m_LastVoteTry + Server()->TickSpeed() * 3 > Server()->Tick())
 		return;
 
-	int64_t Now = Server()->Tick();
-
-	pPlayer->m_LastVoteTry = Now;
+	pPlayer->m_LastVoteTry = Server()->Tick();
 	pPlayer->UpdatePlaytime();
 
 	if(!pMsg->m_Vote)