Use enum instead of int for job state

Robyt3 · Oct 21, 2023 · 9a966fa · 9a966fa
1 parent 09978f3
commit 9a966fa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/engine/shared/jobs.cpp b/src/engine/shared/jobs.cpp
@@ -11,7 +11,7 @@ IJob::IJob() :
 
 IJob::~IJob() = default;
 
-int IJob::Status()
+IJob::EJobState IJob::Status()
 {
 	return m_Status.load();
 }

diff --git a/src/engine/shared/jobs.h b/src/engine/shared/jobs.h
@@ -15,25 +15,26 @@ class IJob
 {
 	friend CJobPool;
 
+public:
+	enum EJobState
+	{
+		STATE_PENDING = 0,
+		STATE_RUNNING,
+		STATE_DONE
+	};
+
 private:
 	std::shared_ptr<IJob> m_pNext;
+	std::atomic<EJobState> m_Status;
 
-	std::atomic<int> m_Status;
 	virtual void Run() = 0;
 
 public:
 	IJob();
 	IJob(const IJob &Other) = delete;
 	IJob &operator=(const IJob &Other) = delete;
 	virtual ~IJob();
-	int Status();
-
-	enum
-	{
-		STATE_PENDING = 0,
-		STATE_RUNNING,
-		STATE_DONE
-	};
+	EJobState Status();
 };
 
 class CJobPool