Fix incorrect loading progress when menu images are added/removed

Do not increment loading progress for individual menu images because the total number of images in the `menuimages` folder might be different than expected. Eventually, menu image loading could be moved to a background job like community icon loading.

Closes ddnet#9497.

src/game/client/components/menus.cpp

@@ -909,9 +909,8 @@ void CMenus::OnInit()
 	m_TextureBlob = Graphics()->LoadTexture("blob.png", IStorage::TYPE_ALL);
 
 	// setup load amount
-	const int NumMenuImages = 5;
 	m_LoadingState.m_Current = 0;
-	m_LoadingState.m_Total = g_pData->m_NumImages + NumMenuImages + GameClient()->ComponentCount();
+	m_LoadingState.m_Total = g_pData->m_NumImages + GameClient()->ComponentCount();
 	if(!g_Config.m_ClThreadsoundloading)
 		m_LoadingState.m_Total += g_pData->m_NumSounds;
 
@@ -2445,7 +2444,7 @@ int CMenus::MenuImageScan(const char *pName, int IsDir, int DirType, void *pUser
 	str_truncate(MenuImage.m_aName, sizeof(MenuImage.m_aName), pName, str_length(pName) - str_length(pExtension));
 	pSelf->m_vMenuImages.push_back(MenuImage);
 
-	pSelf->RenderLoading(Localize("Loading DDNet Client"), Localize("Loading menu images"), 1);
+	pSelf->RenderLoading(Localize("Loading DDNet Client"), Localize("Loading menu images"), 0);
 
 	return 0;
 }