Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] public toggle behavior in channel edit #6123

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Feb 1, 2025

Proposed changes

Changes to fix the "Public" toggle in channel edit section:

  • Toggle state displays incorrectly (ON for private channels, OFF for public channels)
  • Toggle action is reversed (turning it ON makes channels private, OFF makes them public)

Issue(s)

N/A

How to test or reproduce

  1. Create a public channel.
  2. Go to the edit channel section.
  3. Observe the "Public" toggle state.
  4. Toggle the option and save.

Actual Behavior:

  • The "Public" toggle is not visually toggled.
  • Toggling it incorrectly makes the channel private.

Expected Behavior:

  • The "Public" toggle correctly reflects the channel type.
  • Toggling it updates the channel type properly without unintended changes.

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@Rohit3523 Rohit3523 changed the title [fix] public toggle behavior in channel edid [fix] public toggle behavior in channel edit Feb 1, 2025
@Rohit3523
Copy link
Contributor Author

Alternatively we can just change the label to "Private"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant