fix: look for image on url head before rendering preview #6127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtavioStasiak
changed the title
diegolmello
requested changes
Feb 5, 2025
app/containers/message/Urls.tsx
Outdated
| @@ -133,7 +133,7 @@ const Url = ({ url }: { url: IUrl }) => { | |||
| const getImageUrl = () => { | |||
| const imageUrl = url.image || url.url; | |||
|
|
|||
| if (!imageUrl) return null; | |||
| if (!imageUrl || imageUrl.includes('.pdf')) return null; | |||
There was a problem hiding this comment.
What if the pdf doesn't include a .pdf?
diegolmello
reviewed
Feb 13, 2025
diegolmello
changed the title
diegolmello
approved these changes
Feb 13, 2025
|
Looks good to me, much simpler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The app crashes on iOS when a PDF link is sent, as it attempts to render an image preview of the link. To fix this, I added a new rule to getImageUrl to prevent rendering when the link points to a PDF.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-776
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments