Overhaul custom library creation window #759
Draft
+66
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will now ask for a path instead of a file Will create a new .json file on the selected path Custom libraries is now also saved on creation, not only on changes
Create library window will now allow for either manual input of directory, or choosing it through a button File name will be automatically created based on library name if not specified Window was slightly resized to accomodate changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix all bugs outlined on Issue 727.
Changes
An editable line was added to make it easier to manually add a path or change the filename
When only a directory is chosen for the path, a file name will now be automatically created based on the chosen library name
"Ok" button is now disabled if library name is empty
The file dialog will now correctly ask for a path instead of an existing file
Library creation window layout and size was slightly modified to accomodate changes
TODO:
The button for folder selection still needs an icon