Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): removed MenuModal usage in favor of a responsive single HTML menu template #95

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

pixu1980
Copy link
Contributor

@pixu1980 pixu1980 commented Oct 21, 2024

Description

  • Removed MenuModal in favor of a responsive single HTML menu template

Other changes

  • Aligned LangSelector separator width to the MainMenu separator width (2px)
  • Moved fadeInUp animation inside the navbar.module.scss

Bonus ;-)

  • Added stagger animation for menu items in mobile mode
  • Removed underlines for menu items in mobile mode

Notes

  • This is preparatory to fix the Theme Switcher issue add light theme + theme switch #13
  • Considering now the HTML for the menu items is one and only, SEO should benefit from this update

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for romajs ready!

Name Link
🔨 Latest commit e3b7bb1
🔍 Latest deploy log https://app.netlify.com/sites/romajs/deploys/6717df4bea580e000824e4c4
😎 Deploy Preview https://deploy-preview-95--romajs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pixu1980 pixu1980 marked this pull request as ready for review October 21, 2024 22:21
@pixu1980 pixu1980 force-pushed the feat/menu branch 3 times, most recently from ef099ac to 7641fce Compare October 22, 2024 08:15
@FaberVitale FaberVitale merged commit c5a4ea3 into Roma-JS:main Oct 23, 2024
5 checks passed
@FaberVitale FaberVitale mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants