-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable change select on failure #1261
base: main
Are you sure you want to change the base?
enable change select on failure #1261
Conversation
cleanup chat / announcement
🦋 Changeset detectedLatest commit: 4c50dcd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is quite large, with 20 files changed, 1018 lines added, and 661 lines removed. It includes a mix of new features, refactoring, and fixes across various components and modules. To improve the review process and maintainability, it might be beneficial to split this pull request into smaller, more focused ones. Here are some suggestions on how to split the changes:
By splitting the pull request, it will be easier to review and test each set of changes independently, ensuring a smoother integration process. Let me know if you have any questions or need further assistance! |
@@ -513,7 +404,7 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>( | |||
|
|||
highlightLayerRef.current.innerHTML = text | |||
.replace(/\n$/, "\n\n") | |||
.replace(/[<>&]/g, (c) => ({ "<": "<", ">": ">", "&": "&" })[c] || c) | |||
.replace(/[<>&]/g, (c) => ({ "<": "<", ">": ">", "&": "&" })[c] || c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HTML escaping in the highlight update uses replace(/[<>&]/g, ...) and currently only replaces '&' with '&' while leaving '<' and '>' unchanged. For consistency and to prevent potential HTML injection issues, consider replacing '<' with '<' and '>' with '>'.
.replace(/[<>&]/g, (c) => ({ "<": "<", ">": ">", "&": "&" })[c] || c) | |
.replace(/[<>&]/g, (c) => ({ "<": "<", ">": ">", "&": "&" })[c] || c) |
Description
This pull request redesigns the chat window, updates the start screen text, fixes a chat disabling issue, and includes an HTML bug fix. Storybook stories have been added for most components to improve component documentation and development workflow.
Type of change
How Has This Been Tested?
The changes have been tested by manually reviewing the UI changes in the chat window and verifying the fix for the chat disabling issue. Tested with the extension host, and adding images.
Checklist:
Additional context
This PR enhances the user experience and developer workflow by improving the chat interface, providing clearer guidance.
Animation:

Important
Redesigns chat interface, updates start screen, fixes chat disabling, and adds Storybook stories for improved documentation.
ChatView.tsx
.ChatTextArea
,ChatTextAreaInput
,ChatTextAreaActions
,ChatTextAreaSelections
, andChatTextAreaLayout
components.ChatTextArea.module.css
.ChatView.tsx
.defaultExtensionState
toExtensionMessage.ts
for consistent state management.ChatTextArea
andChatView
inChatTextArea.test.tsx
andChatView.test.tsx
.ClineProvider.test.ts
to usedefaultExtensionState
.MCP Servers
command inpackage.json
.This description was created by
for 4c50dcd. It will automatically update as commits are pushed.