-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio Unit initialization fix on macOS #799
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the error:
Error getting supported output configs: BackendSpecific { err: BackendSpecificError { description: "Invalid property value" } }
Find attached output from the example enumerate, with and without the patch.
Please merge.
Best
Andreas
cpal_enumerate_default_N9_daft-panda.txt
cpal_enumerate_default_N9.txt
cpal_enumerate_default_speaker_daft-panda.txt
cpal_enumerate_default_speakers.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a long standing issue on MacOS - It would be great if we can get this merged @est31
I can confirm that this fixes the issues already mentioned for me I have also been experiencing an issue where I can only use certain output devices if they are also selected as the system's output device. By applying this same change in the I'd be happy to put in a separate PR, if that's necessary, but it seems like this change could simply be tacked on to this one |
The current Audio Unit initialization logic produces errors when trying to use output devices as input Audio Units. This results in only some output devices being present when enumerating the host devices.