Merge branch 'main' into testing

.github/workflows/linting.yml

@@ -16,9 +16,9 @@ jobs:
         uses: actions/checkout@v2
       - name: Install dependencies
         run: sudo apt update && sudo apt install jackd2 libjack-jackd2-0 libjack-jackd2-dev
-      - name: Lint (No Features)
+      - name: Lint (Default Features)
         run: cargo clippy --all-targets -- -D clippy::all
-      - name: Lint (metadata)
-        run: cargo clippy --all-targets --no-default-features --features metadata -- -D clippy::all
+      - name: Lint (No features)
+        run: cargo clippy --all-targets --no-default-features -- -D clippy::all
       - name: Cargo Fmt
         run: cargo fmt --check

.github/workflows/testing.yml

@@ -22,13 +22,15 @@ jobs:
         run: jackd -r -ddummy -r44100 -p1024 &
       - name: Install Cargo Nextest
         uses: taiki-e/install-action@nextest
+      - name: Build (Default Features)
+        run: cargo build --verbose 
       - name: Build (No Features)
         run: cargo build --verbose --no-default-features
-      - name: Build (metadata)
-        run: cargo build --verbose --no-default-features --features metadata
       - name: Build (examples)
         run: cargo build --verbose --examples
-      - name: Run Tests
-        run: cargo nextest run --all-features
+      - name: Run Tests (Default Features)
+        run: cargo nextest run
+      - name: Run Tests (No Features)
+        run: cargo nextest run --no-default-features
       - name: Run Doc Tests
         run: cargo doc && cargo test --doc

Cargo.toml

@@ -23,6 +23,5 @@ crossbeam-channel = "0.5"
 ctor = "0.2"
 
 [features]
-default = ["dynamic_loading", "log", "metadata"]
+default = ["dynamic_loading", "log"]
 dynamic_loading = ["jack-sys/dynamic_loading"]
-metadata = []

src/properties.rs

@@ -49,10 +49,8 @@ pub(crate) unsafe extern "C" fn property_changed<P>(
     }
 }
 
-#[cfg(feature = "metadata")]
 pub use metadata::*;
 
-#[cfg(feature = "metadata")]
 mod metadata {
     use super::{j, uuid, PropertyChange, PropertyChangeHandler};
     use crate::Error;
@@ -189,7 +187,6 @@ mod metadata {
         }
     }
 
-    #[cfg(feature = "metadata")]
     impl Client {
         /// Get a property from a subject.
         ///