Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement retail-mac (ISO/IEC 9797-1 MAC Algorithm 3) #170

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

RavuAlHemio
Copy link
Contributor

@RavuAlHemio RavuAlHemio commented Sep 22, 2024

Among other use cases, Retail MAC is used, in combination with DES and ISO 7816 padding, when communicating with the chip in ICAO machine-readable travel documents.

Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor nits, but otherwise the code looks good.

retail-mac/CHANGELOG.md Outdated Show resolved Hide resolved
retail-mac/src/lib.rs Outdated Show resolved Hide resolved
retail-mac/Cargo.toml Outdated Show resolved Hide resolved
@RavuAlHemio
Copy link
Contributor Author

Thanks for the review! I've implemented the requested changes.

Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@newpavlov newpavlov merged commit 698af6b into RustCrypto:master Sep 23, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants