docs: a few usage examples for div #540
Conversation
fix: wrapping_rem_vartime
src/uint/div.rs
Outdated
| @@ -159,6 +159,19 @@ impl<const LIMBS: usize> Uint<LIMBS> { | |||
|
|
|||
| /// Computes `self` % 2^k. Faster than reduce since its a power of 2. | |||
| /// Limited to 2^16-1 since Uint doesn't support higher. | |||
| /// TODO: this is not constant-time. | |||
There was a problem hiding this comment.
Sidebar: we should perhaps consider renaming this rem2k_vartime /cc @fjarri
There was a problem hiding this comment.
I imagine making it constant-time would also be pretty straightforward.
Although I am not sure we need it at all in the API.
|
I just want to reiterate my position (last time, I promise) that usage examples for simple arithmetic operations like these are entirely excessive. |
|
Adds a few usage examples for div operations. ref issue #283.
Additionally modifies:
into:
since it uses
rem_vartimeinternally.