Update ML-DSA sizes #108
Merged
Update ML-DSA sizes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tarcieri I think the ML-DSA PR is close enough to complete that we should go ahead and merge this, then cut a new version. |
6 tasks
tarcieri
reviewed
Dec 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was developed in parallel with RustCrypto/signatures#877, to provide the array sizes necessary for serializing / deserializing ML-DSA keys and signatures. In addition to the end key/signature sizes, some intermediate value sizes are required. It would be OK with me to keep this open until the ML-DSA PR is closer to merging, in case any other required values pop up. (I think it's unlikely at this point, since we're passing all the required tests.) But this PR will need to merge and issue a new version before we can finalize the ML-DSA PR and have CI pass.