Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ml-dsa: implement initial pkcs8/spki traits #891

Merged
merged 2 commits into from
Jan 25, 2025
Merged

ml-dsa: implement initial pkcs8/spki traits #891

merged 2 commits into from
Jan 25, 2025
+390 −2

Conversation

baloo
Copy link
Member

@baloo baloo commented Jan 23, 2025 •
edited
Loading

@baloo baloo changed the title ml-dsa: implement spki ml-dsa: implement spki traits Jan 23, 2025
@baloo baloo force-pushed the baloo/ml-dsa/pkcs8-support branch from ad21bf6 to 2dbe6e9 Compare January 23, 2025 22:42
@baloo
Copy link
Member Author

baloo commented Jan 23, 2025 •
edited
Loading

cc @ArthurHeymans

@baloo baloo force-pushed the baloo/ml-dsa/pkcs8-support branch from 2dbe6e9 to 2cdc9a9 Compare January 23, 2025 23:47
@baloo baloo mentioned this pull request Jan 24, 2025
Merged
baloo
baloo commented Jan 24, 2025
View reviewed changes
ml-dsa/src/lib.rs Outdated Show resolved Hide resolved
@baloo baloo force-pushed the baloo/ml-dsa/pkcs8-support branch 2 times, most recently from 3bb0adb to f83b84a Compare January 24, 2025 05:41
@baloo
Copy link
Member Author

baloo commented Jan 24, 2025

I've pulled this and #892 in a playground: https://github.com/baloo/playground-ml-dsa

tarcieri
tarcieri reviewed Jan 24, 2025
View reviewed changes
ml-dsa/Cargo.toml Outdated Show resolved Hide resolved
tarcieri
tarcieri reviewed Jan 24, 2025
View reviewed changes
ml-dsa/Cargo.toml Outdated Show resolved Hide resolved
@baloo baloo force-pushed the baloo/ml-dsa/pkcs8-support branch 2 times, most recently from fd0fbee to b605aca Compare January 24, 2025 18:22
@baloo baloo marked this pull request as draft January 24, 2025 19:17
@baloo baloo force-pushed the baloo/ml-dsa/pkcs8-support branch from b605aca to ea0889b Compare January 24, 2025 21:19
@baloo baloo force-pushed the baloo/ml-dsa/pkcs8-support branch from ea0889b to c374e3b Compare January 24, 2025 21:21
@baloo baloo marked this pull request as ready for review January 24, 2025 21:21
tarcieri
tarcieri reviewed Jan 25, 2025
View reviewed changes
ml-dsa/Cargo.toml Outdated Show resolved Hide resolved
@tarcieri tarcieri merged commit f7e7312 into RustCrypto:master Jan 25, 2025
47 checks passed
@tarcieri tarcieri changed the title ml-dsa: implement spki traits ml-dsa: implement initial pkcs8/spki traits Jan 25, 2025
@baloo baloo deleted the baloo/ml-dsa/pkcs8-support branch January 26, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri left review comments

@bifurcation bifurcation Awaiting requested review from bifurcation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: Implement spki traits on ML-DSA
2 participants
@baloo @tarcieri